python scripts: enable standard type checking #14321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix all the type issues, enable checking so that no more creep in. A couple third-party libraries have some issues (such as totally wrong typing), I just disabled in that case. Fixes are mostly basic stuff such as adding missing null checks, occasional cast or type-hint.
|
After this PR, i'd like to run |
dweiss
approved these changes
Mar 2, 2025
rmuir
added a commit
that referenced
this pull request
Mar 2, 2025
Fix all the type issues, enable checking so that no more creep in. A couple third-party libraries have some issues (such as totally wrong typing), I just disabled in that case. Fixes are mostly basic stuff such as adding missing null checks, occasional cast or type-hint.
hanbj
pushed a commit
to hanbj/lucene
that referenced
this pull request
Mar 12, 2025
Fix all the type issues, enable checking so that no more creep in. A couple third-party libraries have some issues (such as totally wrong typing), I just disabled in that case. Fixes are mostly basic stuff such as adding missing null checks, occasional cast or type-hint.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all the type issues, enable checking so that no more creep in.
A couple third-party libraries have some issues (such as totally wrong typing), I just disabled in that case.
Fixes are mostly basic stuff such as adding missing null checks, occasional cast or type-hint.